Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAC-6407] fix ucs debian fit test bug #916

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HQebupt
Copy link
Contributor

@HQebupt HQebupt commented Dec 5, 2017

During the ucs-service debian fit test, there is no ucs.fan poller in the test environment here.
So the fit test has one failer.

curl -k GET   'https://1.2.3.4:7080/pollers?identifier=sys%2Fchassis-3&classIds=equipmentFanStats'   -H 'ucs-host: 10.62.xx.xx'   -H 'ucs-password: ****'   -H 'ucs-user: ucspe'

{
  "equipmentFanStats": []
} 

Can we remove the if judgement ?

@bbcyyb @pengz1

@HQebupt HQebupt changed the title [RAC-6407] fix ucs debian fit bug [RAC-6407] fix ucs debian fit test bug Dec 5, 2017
@pengz1
Copy link
Member

pengz1 commented Dec 5, 2017

You should clarify two things: fan poller doesn't exist in UCSPE or it doesn't exist in this kind of nodes.

If it only doesn't exist in UCSPE but exists in bare mental nodes, you should consider skip it instead of removing it in case bare mental tests require it.

@pengz1 pengz1 added the run-test label Dec 5, 2017
@HQebupt
Copy link
Contributor Author

HQebupt commented Dec 5, 2017

It makes sense. Thanks. I will skip the test, and close the issue.

@panpan0000
Copy link
Contributor

:+0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants