Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[arm64] add hw thread self #8942

Merged
merged 4 commits into from
May 28, 2024

Conversation

polarvid
Copy link
Contributor

@polarvid polarvid commented May 13, 2024

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

This patch introduces hardware-based thread self-identification
for the AArch64 architecture. It optimizes thread management by
using hardware registers to store and access the current thread's
pointer, reducing overhead and improving overall performance.

你的解决方案是什么 (what is your solution)

Changes include:

  • Added ARCH_USING_HW_THREAD_SELF configuration option.
  • Modified rtdef.h, rtsched.h to conditionally include
    critical_switch_flag based on the new config.
  • Updated context management in context_gcc.S, cpuport.h
    to support hardware-based thread self.
  • Enhanced scheduler_mp.c and thread.c to leverage the new
    hardware thread self feature.

These modifications ensure better scheduling and thread handling,
particularly in multi-core environments, by minimizing the
software overhead associated with thread management.

请提供验证的bsp和config (provide the config and bsp)

  • BSP: orangepi cm4 in UP; SMP,single-core; SMP, quad-core
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@polarvid polarvid force-pushed the shell/hw-thread-self branch 2 times, most recently from e6a7cd3 to d1dd50a Compare May 14, 2024 05:18
@polarvid polarvid marked this pull request as ready for review May 17, 2024 07:23
Copy link
Member

@BernardXiong BernardXiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

或许可以沟通下,这个行为意图是什么样的,是否有更好的代码实现方式

include/rtsched.h Outdated Show resolved Hide resolved
src/scheduler_mp.c Outdated Show resolved Hide resolved
@polarvid
Copy link
Contributor Author

很多代码依赖于 rt_current_thread 作为全局变量。

src/thread.c Outdated Show resolved Hide resolved
@polarvid polarvid marked this pull request as draft May 22, 2024 06:02
@polarvid polarvid mentioned this pull request May 22, 2024
9 tasks
This patch introduces hardware-based thread self-identification
for the AArch64 architecture. It optimizes thread management by
using hardware registers to store and access the current thread's
pointer, reducing overhead and improving overall performance.

Changes include:
- Added `ARCH_USING_HW_THREAD_SELF` configuration option.
- Modified `rtdef.h`, `rtsched.h` to conditionally include
  `critical_switch_flag` based on the new config.
- Updated context management in `context_gcc.S`, `cpuport.h`
  to support hardware-based thread self.
- Enhanced `scheduler_mp.c` and `thread.c` to leverage the new
  hardware thread self feature.

These modifications ensure better scheduling and thread handling,
particularly in multi-core environments, by minimizing the
software overhead associated with thread management.

Signed-off-by: Shell <[email protected]>
Also, maintain the rt_current_thread in cpu object on UP scheduler.
@polarvid polarvid marked this pull request as ready for review May 27, 2024 07:21
@BernardXiong BernardXiong merged commit f17f994 into RT-Thread:master May 28, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants