Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kconfig] remove RT_USING_SCHED_THREAD_CTX #8895

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

polarvid
Copy link
Contributor

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

Remove compatible definition for v5.1.0 and before.

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

Remove compatible definition for v5.1.0 and before.

Signed-off-by: Shell <[email protected]>
@polarvid polarvid changed the title remove RT_USING_SCHED_THREAD_CTX [include] remove RT_USING_SCHED_THREAD_CTX Apr 30, 2024
@polarvid polarvid changed the title [include] remove RT_USING_SCHED_THREAD_CTX [kconfig] remove RT_USING_SCHED_THREAD_CTX Apr 30, 2024
@polarvid polarvid requested a review from mysterywolf May 1, 2024 02:13
@mysterywolf
Copy link
Member

image
image

这两个报错不用理,这3个是因为软件包兼容报错,我来处理。剩下的错误除了格式CI之外,应该需要处理一下。

@mysterywolf
Copy link
Member

mysterywolf commented May 1, 2024

修复commit请独立提交,不要force push,如果出问题,方便revert,尽量把commit拆碎,提交个20 30个都没问题,review没有问题之后我可以重新rebase

@mysterywolf
Copy link
Member

image
这种错误其实可以顺道增加几个API 直接获取thread状态,避免用户直接操作thread结构体

@polarvid
Copy link
Contributor Author

polarvid commented May 1, 2024

image 这种错误其实可以顺道增加几个API 直接获取thread状态,避免用户直接操作thread结构体

Updated in #8897

@mysterywolf mysterywolf closed this May 4, 2024
@mysterywolf mysterywolf reopened this May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants