Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools] make env path respect XDG Base Directory specification #8497

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wirano
Copy link
Contributor

@wirano wirano commented Jan 19, 2024

拉取/合并请求描述:(PR description)

The XDG Base Directory Specification is established by Freedesktop.org, aiming to standardize the storage paths of application files and solve the disorderly state of various dot files in the user's home directory.

This PR sets env tool path to $XDG_DATA_HOME/rt-thread/env to respect the XDG Base Directory specification, keep compatibility with the old ~/.env path.

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@CLAassistant
Copy link

CLAassistant commented Jan 19, 2024

CLA assistant check
All committers have signed the CLA.

@mysterywolf mysterywolf marked this pull request as draft January 20, 2024 17:33
@BernardXiong
Copy link
Member

大概也需要同步更新文档

@wirano
Copy link
Contributor Author

wirano commented Jan 29, 2024

大概也需要同步更新文档

@BernardXiong

ok 目前看来改动部分比较多,env 相关安装脚本也需要改,我会继续整理。

另外,考虑到修改后的 env 路径较长,手动 source 可能不太方便,是否可以添加 scons --active-env 选项激活 env 环境。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants