Improve kokkos trace handling. #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuchen-amd
requested review from
koomie,
coleramos425,
feizheng10 and
dgaliffiAMD
as code owners
xuchen-amd
changed the title
feizheng10
reviewed
Feb 20, 2025
feizheng10
reviewed
Feb 20, 2025
| results_files_csv = glob.glob(workload_dir + "/out/pmc_1/*/*_converted.csv") | ||
| elif is_timestamps: | ||
| # when the input is timestamps, we know counter csv file is not generated and will instead parse kernel trace file | ||
| results_files_csv = glob.glob( |
There was a problem hiding this comment.
Not a big deal but path lib should be better than glob
There was a problem hiding this comment.
results_files_csv is returned and to expected to be looped through as string type to pass to pd.read_csv(). In future refactoring, I can address this problem to handle paths with more robustness.
feizheng10
reviewed
Feb 20, 2025
…ler-compute into improve_kokkos_trace
feizheng10
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run_prof()to improve readability for rocprofv3 output processing--kokkos-traceoutput processing for rocprofv3 supportjoin_prof()with--hip-traceand--kokkos-tracecompatibility