Skip to content

Fix recent changes of universal_gemm in tile_engine #2344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

amd-khushbu
Copy link
Collaborator

Proposed changes

  1. Fix tile_engine code for incorporating the recent changes made in the kernel arguments and Cshuffle epilogue.
  2. For the time being, Disabling Default Epilogue from tile_engine.

Checklist

Please put an x into the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.

  • I have added tests relevant to the introduced functionality, and the unit tests are passing locally
  • I have added the test to REGRESSION_TESTS list defined at the top of CMakeLists.txt in tests/CMakeLists.txt, IF the test takes more than 30 seconds to run.
  • I have added inline documentation which enables the maintainers with understanding the motivation
  • I have removed the stale documentation which is no longer relevant after this pull request
  • (If this change is user-facing) I have added release notes which provide the end users with a brief summary of the improvement from this pull request
  • I have run clang-format on all changed files
  • Any dependent changes have been merged

Discussion

If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered

ThomasNing
ThomasNing previously approved these changes Jun 14, 2025
mozga-amd
mozga-amd previously approved these changes Jun 16, 2025
@AviralGoelAMD
Copy link
Collaborator

PR merged into #2267.

@amd-khushbu amd-khushbu dismissed stale reviews from mozga-amd and ThomasNing via 312e9f8 June 18, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants