Skip to content

[CK_TILE] moe_sorting support "local_tokens" feature for EP case #2335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 18, 2025

Conversation

carlushuang
Copy link
Contributor

@carlushuang carlushuang commented Jun 12, 2025

Proposed changes

support token passed in from another GPU buffer, this is used for EP case dispatch/combine where the remote ranks may receive different num of tokens

Checklist

Please put an x into the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.

  • I have added tests relevant to the introduced functionality, and the unit tests are passing locally
  • I have added the test to REGRESSION_TESTS list defined at the top of CMakeLists.txt in tests/CMakeLists.txt, IF the test takes more than 30 seconds to run.
  • I have added inline documentation which enables the maintainers with understanding the motivation
  • I have removed the stale documentation which is no longer relevant after this pull request
  • (If this change is user-facing) I have added release notes which provide the end users with a brief summary of the improvement from this pull request
  • I have run clang-format on all changed files
  • Any dependent changes have been merged

Discussion

If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered

@carlushuang carlushuang requested a review from a team as a code owner June 12, 2025 13:16
asleepzzz
asleepzzz previously approved these changes Jun 12, 2025
Copy link
Contributor

@spolifroni-amd spolifroni-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The readme needs a bit of smoothing, contextualizing, and clarification.

@carlushuang carlushuang changed the title [CK_TILE] moe_sorting support dynamic token, used for EP case [CK_TILE] moe_sorting support local_tokens for EP case Jun 15, 2025
@carlushuang carlushuang changed the title [CK_TILE] moe_sorting support local_tokens for EP case [CK_TILE] moe_sorting support "local_tokens" feature for EP case Jun 15, 2025
@illsilin illsilin dismissed spolifroni-amd’s stale review June 18, 2025 02:46

I think all the comments have been addressed adequately.

@carlushuang carlushuang merged commit a4e1248 into develop Jun 18, 2025
39 of 45 checks passed
@carlushuang carlushuang deleted the ck_tile/sorting_local_token branch June 18, 2025 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants