Grouped convolution forward with clamp #2334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartekxk
requested review from
illsilin,
carlushuang,
qianfengz,
aosewski,
poyenc,
geyyer,
andriy-ca,
afagaj,
asleepzzz,
ThomasNing,
coderfeli,
a team and
tenpercent
as code owners
bartekxk
force-pushed
the
barkocot/lwpck-3306
branch
from
3bcc59c to
2d4c512
Compare
bartekxk
force-pushed
the
barkocot/lwpck-3306
branch
from
2913cac to
aeb0cb2
Compare
geyyer
previously approved these changes
Jun 13, 2025
| @@ -255,7 +293,7 @@ bool profile_grouped_conv_fwd_bias_clamp_impl(int do_verification, | |||
| b_g_k_c_xs_lengths, | |||
| b_g_k_c_xs_strides, | |||
| {e_g_n_k_wos_lengths}, | |||
There was a problem hiding this comment.
Should we update lengths e_g_n_k_wos_lengths->d_g_n_k_wos_lengths as well?
There was a problem hiding this comment.
I added an information that GK implementation is just workaround and it should be refactored in the future.
This reverts commit 8e42e29.
geyyer
approved these changes
Jun 16, 2025
|
After previous CI passed I only added the comment. Failed tests are unrelated to this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Grouped convolution forward with clamp.
Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed filesDiscussion
If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered