Skip to content

Add function to print slices of tensors to help debug #2323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

AviralGoelAMD
Copy link
Collaborator

@AviralGoelAMD AviralGoelAMD commented Jun 10, 2025

Proposed changes

This PR adds a new function to check_err.hpp void compare_vector_range(const Range1& vec1, const Range2& vec2, size_t start_index, size_t num_elements, const std::string& msg = "Comparing Results:")

It lets the user pass two tensors, a starting index & number of elements to then print those values side by side to compare.

The PR also includes refactoring (moving a function out of gemm_example.inc to check_err) and documentation.

Checklist

Please put an x into the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.

  • I have added tests relevant to the introduced functionality, and the unit tests are passing locally
  • I have added the test to REGRESSION_TESTS list defined at the top of CMakeLists.txt in tests/CMakeLists.txt, IF the test takes more than 30 seconds to run.
  • I have added inline documentation which enables the maintainers with understanding the motivation
  • I have removed the stale documentation which is no longer relevant after this pull request
  • (If this change is user-facing) I have added release notes which provide the end users with a brief summary of the improvement from this pull request
  • I have run clang-format on all changed files
  • Any dependent changes have been merged

Discussion

If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered

@AviralGoelAMD AviralGoelAMD added the documentation Improvements or additions to documentation label Jun 10, 2025
@AviralGoelAMD AviralGoelAMD marked this pull request as ready for review June 10, 2025 16:50
ThomasNing
ThomasNing previously approved these changes Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants