2217 add io module for profiler #2287
Open
+1,002
−264
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
As described in the issue this is an effort to extend and improve the output of CK Profiler.
Discussion
This pull request is more to have a conversation around than a final implementation.
Disclaimer, the author is not experienced in C++. Input and feedback on how to do things in a more idiomatic way is welcome.
What's in the PR
This PR includes
Output Format
The output format is intended to capture the same data as the current implementations, and be flexible enough to support the different kinds of operations available.
What is NOT in the PR
The PR has only updated
profiler/include/profiler/profile_gemm_impl.hpp
to use the new io_profiler functions.If this approach to output is accepted, all the output logic will live in io_profiler. Therefore all the implementation headers must be updated to leverage it.
It does not capture meta data like GPU name, architecture, CK version, etc
Example
Tested on Radeon RX 7900 XT
./bin/ckProfiler gemm 1 2 1 2 0 1 3840 4096 4096 4096 4096 4096 5 10 -o jsonl=result.jsonl
Output truncated for brevity