Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HIP supported GPUs #3493

Merged
merged 1 commit into from
May 28, 2024
Merged

HIP supported GPUs #3493

merged 1 commit into from
May 28, 2024

Conversation

neon60
Copy link
Contributor

@neon60 neon60 commented May 22, 2024

HIP supported GPUs

@neon60
Copy link
Contributor Author

neon60 commented May 23, 2024

Here's the text:
HIP is supported on some AMD GPUs and multiple operating systems. For more information, see:
• Linux system requirements
• Microsoft Windows system requirements
HIP is also supported on NVIDIA GPUs, which must be CUDA-enabled. For more information about supported NVIDIA GPUs, see GPU Compute Capability.

@neon60
Copy link
Contributor Author

neon60 commented May 23, 2024

Here's the text: HIP is supported on some AMD GPUs and multiple operating systems. For more information, see: • Linux system requirements • Microsoft Windows system requirements HIP is also supported on NVIDIA GPUs, which must be CUDA-enabled. For more information about supported NVIDIA GPUs, see GPU Compute Capability.

@lpaoletti @randyh62 I think this sentence is not fully in alignment with the first statement: "HIP is a C++ runtime API and kernel language that lets developers create portable applications for AMD and NVIDIA GPUs from single source code."

We are duplicating the information in these sentences and first statement.:

"HIP is supported on some AMD GPUs and multiple operating systems. HIP is also supported on NVIDIA GPUs, which must be CUDA-enabled"

Added a suggestion commit:

d0100a6

lpaoletti
lpaoletti approved these changes May 27, 2024
View reviewed changes
Copy link

@lpaoletti lpaoletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving your suggestion.
Also note Randy has a change at the top of the page:
https://github.com/ROCm/HIP/pull/3492/files

@neon60 neon60 force-pushed the hip_supported_gpus branch 2 times, most recently from dabce69 to 3ff2853 Compare May 28, 2024 13:33
@neon60
Copy link
Contributor Author

neon60 commented May 28, 2024

Approving your suggestion. Also note Randy has a change at the top of the page: https://github.com/ROCm/HIP/pull/3492/files

Merged in the PR which was mentioned to docs/develop.

@neon60 neon60 requested a review from lpaoletti May 28, 2024 13:39
@neon60
HIP supported GPUs
9a60101 
- Suggestion
- Fix CUDA GPUs link
- Remove incorrect only phrase
- MD fix
- Fix link
lpaoletti
lpaoletti approved these changes May 28, 2024
View reviewed changes
Copy link

@lpaoletti lpaoletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@neon60 neon60 merged commit b8189b7 into docs/develop May 28, 2024
3 checks passed
@neon60 neon60 deleted the hip_supported_gpus branch June 10, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpaoletti lpaoletti lpaoletti approved these changes

@gandryey gandryey Awaiting requested review from gandryey gandryey is a code owner

@mangupta mangupta Awaiting requested review from mangupta mangupta is a code owner

@rakesroy rakesroy Awaiting requested review from rakesroy rakesroy is a code owner

@matyas-streamhpc matyas-streamhpc Awaiting requested review from matyas-streamhpc

@parbenc parbenc Awaiting requested review from parbenc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neon60 @lpaoletti