Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dtt params to filter table + general config updates #395

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

asyates
Copy link
Contributor

@asyates asyates commented Feb 6, 2025

Afew things added/changed. I still want to make some further adjustments (listed below), but if there is any feedback on these changes i.e. whether they're wanted or not, or if there is a better way of doing it, would be useful before merging.

Changes:

  • dtt_minlag, dtt_width, and dtt_v, moved to filter table. I've always personally, at least for dtt_minlag and dtt_width, adjusted the code to have these defined for individually for each filter as makes the most sense to me (especially for single station). dtt_v, could go either way... ofc could expect different ballistic velocity at different frequencies, but seems less important maybe to define individually.

  • config sql table contains used_in field which is a list of steps where it is used/defined. It can be used as a filter on msnoise admin (originally was looking to do this without having it as a column in the sql table, only in defaults.csv, but was easier just including it in the config table... and just not showing it on admin).

  • adjusted some of parameters in wavelet codes (from using 'dtt' to 'wct') to make it clear they are wavelet related, e.g. wct_minlag, wct_codacycles, wct_min_nonzero. Might rename some of these variables anyway actually, as i just chose them quickly when writing the code.

Some images of the changes

filter table new columns:
filter_admin1

dropdown option in config with used_in filter:
msnoise_admin3
msnoise_admin2

wct param name changes:
msnoise_admin4**

To do (related to param changes)

  • Double check documentation, probably needs some updates.
  • Adjust wavelet code to also include option for static lag times. Also, some of the 'default' choices should be changed.

As said, feedback welcome re. any of this!

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 87.87879% with 12 lines in your changes missing coverage. Please review.

Project coverage is 63.66%. Comparing base (6fe4a6b) to head (def8aad).

Files with missing lines Patch % Lines
msnoise/api.py 54.54% 5 Missing ⚠️
msnoise/plots/dvvs.py 0.00% 2 Missing ⚠️
msnoise/s03compute_cc.py 0.00% 2 Missing ⚠️
msnoise/s06compute_dtt2.py 75.00% 2 Missing ⚠️
msnoise/msnoise_admin.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #395   +/-   ##
=======================================
  Coverage   63.66%   63.66%           
=======================================
  Files          44       44           
  Lines        7672     7685   +13     
=======================================
+ Hits         4884     4893    +9     
- Misses       2788     2792    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asyates
Copy link
Contributor Author

asyates commented Feb 11, 2025

Removed mwcs_low and mwcs_high, and renamed 'low' and 'high' to freqmin and freqmax to match obspy definitions.

image

To do on this pull request

  • renaming and some additions of wct_params (static and dynamic lag time).
  • renaming of some dtt_ params to mwcs_ (e.g. dtt_coh, dtt_maxerr)
  • change of max_dt to max_dtt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant