Fix some cross-module definition calls #53
Conversation
| return result.value | ||
|
|
||
| // TODO This doesn't work in all cases https://github.com/RLovelett/langserver-swift/issues/52 | ||
| let interModuleResult = SourceKit.CursorInfo(source: source.text, source: at.textDocument.uri, offset: offset, args: module.arguments + modules.flatMap { $0.sources.keys.map { $0.path } }) |
There was a problem hiding this comment.
While I get that this likely works in this case. It does not seem to generalize well. Can you confirm how this would handle a case where you have two modules, e.g., ModuleA and ModuleB, both define a protocol/struct/class of the same name?
There was a problem hiding this comment.
I tried this: I copied RequestBuffer.swift from the BaseProtocol module to the LanguageServerProtocol module, then when I did a go-to-def on main.swift:11 RequestBuffer(), it took me to the RequestBuffer in LanguageServerProtocol. I have no idea if that was an arbitrary choice by SourceKit, or if the order of the command line arguments mattered, or what.
|
I probably don't actually understand this much more than you do. My guess is that providing more |
Before:
After:
Admittedly, this doesn't work in all cases (e.g. the call to
SourceKit.CodeCompletein #52), which is pretty ironic because that's the case that I tried to fix 😒If anyone has any tips for figuring out what arguments to pass to
swiftto get it to resolve these properly, that would be very helpful, because so far my best strategy is Try Random Combinations And Hope It Works ™️