Use International Components for Unicode (ICU) to parse line breaks #51
Conversation
|
|
||
| } | ||
|
|
||
| struct Line { |
There was a problem hiding this comment.
Add some documentation to Line to make sure we can remember what each of the fields is for.
| let last: Bool | ||
|
|
||
| func contains(_ index: String.Index) -> Bool { | ||
| if last { |
There was a problem hiding this comment.
Document why this condition is here. I know there is a failing test case for it.
|
|
||
| private var lineNumber: Int | ||
|
|
||
| private var handleTrailingNewLine: Bool |
There was a problem hiding this comment.
Document what handleTrailingNewLine is really trying to do. Probably needs a better name too.
| } | ||
|
|
||
| mutating func next() -> Line? { | ||
| guard cursor < text.endIndex else { |
There was a problem hiding this comment.
This next function is a mess.
| /// - Parameter offset: The offset from the start of the TextDocument. | ||
| /// - Returns: A new and valid Position. | ||
| /// - Throws: WorkspaceError.positionNotFound if the offset is not within the bounds of the TextDocument. | ||
| func position(for offset: Int) throws -> Position { |
There was a problem hiding this comment.
Does this make more sense as a function on TextDocument or as an initializer on Position that takes a TextDocument and offset? 🤔
| return try! String(contentsOf: url) | ||
| }() | ||
|
|
||
| override func setUp() { |
There was a problem hiding this comment.
Delete these since they are not used.
| } | ||
|
|
||
| func testLastLine() { | ||
| for line in AnySequence({ LineIterator(self.simpleBar) }) { |
There was a problem hiding this comment.
Do this for all of the documents and find a way to abstract it so that it is not so verbose.
I am trying to improve the robustness of the
selection(startAt:,length:)andbyteOffset(at:)which had a tendency to not be able to translate positions over time.These errors.