Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FWT-16 We CAN do 2 For 4 #111

Merged
merged 9 commits into from
Nov 11, 2024
Merged

FWT-16 We CAN do 2 For 4 #111

merged 9 commits into from
Nov 11, 2024

Conversation

mjh9585
Copy link
Contributor

@mjh9585 mjh9585 commented Nov 4, 2024

Adds dual CAN bus support for STM32F446xx in EVT-core.

  • Adds base CAN bus support to STM32F446xx
    • Support CAN 1 hardware
    • Support CAN 2 hardware
  • Allows simultaneous CAN bus usage on both interfaces

Screenshot 2024-11-03 224051

@mjh9585 mjh9585 requested review from mjmagee991 and a team November 4, 2024 04:25
Ethan-Caracoglia
Ethan-Caracoglia approved these changes Nov 8, 2024
View reviewed changes
Copy link

@Ethan-Caracoglia Ethan-Caracoglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

include/core/io/CAN.hpp Show resolved Hide resolved
mjmagee991
mjmagee991 requested changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@mjmagee991 mjmagee991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some cleanup, but looks great

.gitignore Show resolved Hide resolved
include/core/io/CAN.hpp Show resolved Hide resolved
include/core/io/platform/f4xx/CANf4xx.hpp Outdated Show resolved Hide resolved
src/core/io/platform/f4xx/CANf4xx.cpp Outdated Show resolved Hide resolved
include/core/manager.hpp Show resolved Hide resolved
src/core/io/platform/f4xx/CANf4xx.cpp Outdated Show resolved Hide resolved
src/core/io/platform/f4xx/CANf4xx.cpp Outdated Show resolved Hide resolved
src/core/io/platform/f4xx/CANf4xx.cpp Outdated Show resolved Hide resolved
src/core/io/platform/f4xx/CANf4xx.cpp Outdated Show resolved Hide resolved
src/core/io/platform/f4xx/CANf4xx.cpp Outdated Show resolved Hide resolved
mjmagee991
mjmagee991 approved these changes Nov 9, 2024
View reviewed changes
Copy link
Contributor

@mjmagee991 mjmagee991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

include/core/io/platform/f4xx/CANf4xx.hpp Outdated Show resolved Hide resolved
include/core/io/platform/f4xx/CANf4xx.hpp Show resolved Hide resolved
samples/can/multiCAN/README.md Show resolved Hide resolved
samples/can/multiCAN/main.cpp Outdated Show resolved Hide resolved
src/core/io/platform/f4xx/CANf4xx.cpp Outdated Show resolved Hide resolved
src/core/io/platform/f4xx/CANf4xx.cpp Show resolved Hide resolved
@mjh9585 mjh9585 merged commit b67f79b into main Nov 11, 2024
1 check passed
@mjh9585 mjh9585 deleted the feature/mjh9585/F446x-CAN branch November 11, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ethan-Caracoglia Ethan-Caracoglia Ethan-Caracoglia approved these changes

@mjmagee991 mjmagee991 mjmagee991 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjh9585 @mjmagee991 @Ethan-Caracoglia