In V4 the BMS Doesn't Work Again #23
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mjmagee991
commented
Jul 21, 2025
mjmagee991
commented
- Added BQ reset pin
- Added error LED pin
- Added reset and error logic to take advantage of new pins
aclowmclaughlin
approved these changes
Jul 23, 2025
Contributor
aclowmclaughlin
left a comment
aclowmclaughlin
left a comment
There was a problem hiding this comment.
Looks good- is there a reason that the bq reset wasn't implemented initially?
Not important just curious.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.