Skip to content

sys/net/gnrc/network_layer/ipv6/nib: Fixed a compile error on non-existing variable abr in _handle_6co#22246

Open
Sanderhuisman wants to merge 1 commit into
RIOT-OS:masterfrom
Sanderhuisman:nib-6ln-handle-6co-missing-variable
Open

sys/net/gnrc/network_layer/ipv6/nib: Fixed a compile error on non-existing variable abr in _handle_6co#22246
Sanderhuisman wants to merge 1 commit into
RIOT-OS:masterfrom
Sanderhuisman:nib-6ln-handle-6co-missing-variable

Conversation

@Sanderhuisman
Copy link
Copy Markdown
Contributor

Contribution description

In the _handle_6co function (_nib-6ln.c), the (void)abr should only be used when CONFIG_GNRC_IPV6_NIB_MULTIHOP_P6C is active. When multihop P6C is not active, the abr variable does not exist.

Testing procedure

Issues/PRs references

Declaration of AI-Tools / LLMs usage:

AI-Tools / LLMs that were used are:

  • none

@Sanderhuisman Sanderhuisman requested a review from miri64 as a code owner May 6, 2026 11:44
@github-actions github-actions Bot added Area: network Area: Networking Area: sys Area: System labels May 6, 2026
@crasbe crasbe added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 6, 2026
@AnnsAnns
Copy link
Copy Markdown
Member

AnnsAnns commented May 6, 2026

Hey, thank you for your contribution to RIOT. Was it intentional to link your commit to a different Github account?

Also, see here: #22245 (comment)

@Sanderhuisman Sanderhuisman changed the title Fixed a compile error on non-existing variable abr in _handle_6co sys/net/gnrc/network_layer/ipv6/nib: Fixed a compile error on non-existing variable abr in _handle_6co May 8, 2026
@Sanderhuisman Sanderhuisman force-pushed the nib-6ln-handle-6co-missing-variable branch from 39e1de3 to b573cef Compare May 8, 2026 10:45
@Sanderhuisman
Copy link
Copy Markdown
Contributor Author

@AnnsAnns it wasn't intentional, but rather a mixup between two accounts ;)

@riot-ci
Copy link
Copy Markdown

riot-ci commented May 8, 2026

Murdock results

✔️ PASSED

b573cef sys/net/gnrc/network_layer/ipv6/nib: Fixed a compile error on non-existing variable abr in _handle_6co.

Success Failures Total Runtime
11108 0 11108 10m:30s

Artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants