Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basereq #143

Merged
merged 13 commits into from
Feb 9, 2024
Merged

Basereq #143

merged 13 commits into from
Feb 9, 2024

Conversation

JosiahParry
Copy link
Collaborator

Checklist

  • update NEWS.md
  • documentation updated with devtools::document()
  • devtools::check() passes locally

Changes

This PR addresses the authorization token overhaul introduced in R-ArcGIS/arcgisutils#19.

  • It ensures that all functions that generate tokens use arcgisutils::arc_base_req() to appropriately check and add a token.
  • removes any host argument and instead, fetches the host from the token
  • replaces mentions of set_auth_token()to set_arc_token()
  • minor changes of jsonify::from_json() to RcppSimdJson::fparse()
  • updates tests and adds a new truncate_layer() test
  • removes the authorization vignette. favor the one at r.esri.com
    Issues that this closes

Please link any issues that are closed by this PR

Follow up tasks

  • find instances of set_auth_token() host = in r.esri.com docs and replace accordingly

@JosiahParry
Copy link
Collaborator Author

CI is going to fail until R-ArcGIS/arcgisutils#19 is merged. And even then it may continue to fail if it installs the package from CRAN. Ideally, for CI purposes, it will install from the github repo.

@JosiahParry JosiahParry merged commit 0edd537 into main Feb 9, 2024
1 of 7 checks passed
@JosiahParry JosiahParry deleted the basereq branch September 26, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant