Skip to content

Insights: fixed for local development and q-manifest submissions #7642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

shairez
Copy link
Contributor

@shairez shairez commented May 26, 2025

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

Fixed the insights app for local development and also q-manifest sending.

Improved the design a bit by using qwik-ui tooltip
(for now I kept it 0.5.0 because the docs use the same version, but we'll upgrade later and make the wrapper with less any :) )

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@shairez shairez requested review from a team as code owners May 26, 2025 08:48
@shairez shairez self-assigned this May 26, 2025
Copy link

changeset-bot bot commented May 26, 2025

🦋 Changeset detected

Latest commit: c99dc59

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik Patch
eslint-plugin-qwik Patch
@builder.io/qwik-city Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@shairez shairez requested a review from mhevery May 26, 2025 08:49
Copy link

changeset-bot bot commented May 26, 2025

⚠️ No Changeset found

Latest commit: 72d996d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -99,9 +99,10 @@ export const symbolDetailTable = sqliteTable(
hi: integer('hi').notNull(),
},
(symbolDetailTable) => ({
apiKeyManifestHashIndex: uniqueIndex('idx_symbolDetail_apiKey_manifestHash').on(
apiKeyManifestHashIndex: uniqueIndex('idx_symbolDetail_apiKey_manifestHash_hash').on(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhevery please look at this and see if it's OK.
because I remember us having issues with the indexing.

This specifically fixes an sql error when submitting a q-manifest via the vite plugin

@shairez shairez force-pushed the pr-fix-insights-app branch from 72d996d to c99dc59 Compare May 26, 2025 12:07
Copy link
Contributor

github-actions bot commented May 26, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview c99dc59

@wmertens wmertens changed the title Insights: fixed for local development and q-manifest sumbissions Insights: fixed for local development and q-manifest submissions Jun 2, 2025
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

2 participants