Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Massive Refactor #71

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Massive Refactor #71

wants to merge 2 commits into from

Conversation

Ansraer
Copy link

@Ansraer Ansraer commented Feb 29, 2024

Ok, this is the current state of my refactor. I did the following:

  • Ensure all class names are UpperCamelCase
  • Added a clang-format file to the root of the repo with rules that mostly match the current coding style.
  • Move device related stuff into platform/device. Hopefully this should keep some of the random device checks out of the codebase
    • In the future please try to avoid if(deviceID==X)
  • started cleaning up functions.h Ideally that file should be entirely gone in the future
  • some work to get this running on desktop in the future
  • removed some duplicated/dead code

@tux-linux
Copy link
Contributor

tux-linux commented Jul 24, 2024

Hi @Ansraer , I tried your refactor this week and it makes the binary hang on start.

iniparser: cannot open /mnt/onboard/.kobo/nightmode.ini
cat: can't open '/mnt/onboard/.kobo/Kobo/Kobo eReader.conf': No such file or directory
QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/runtime-root'
21/07/2024 @ 13:04:00 | main: Running on device n705

No further output comes after that; I attached an strace log I got from my Kobo Mini to this message.
Thanks for your work and sorry to review it so late... I hope you will be able to help, because debugging a 11000-line diff is quite difficult when you are not the one who wrote the code...
message.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants