-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: automatic package manager install
when autofixing
#71
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, and glad that it's your first time writing Rust!
Could you change the behavior to automatically run an install after --fix
is run, unless we pass --no-install
? We don't need to ask the user given we'll already have an option to disable it.
Install now runs automatically. Will add some more tests and polish when I have the time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the huge delay on this PR, here's some feedback.
I wonder why we didn't already have -f
as a shorthand for --fix
, great addition 👍
Co-authored-by: Tom Lienard <[email protected]>
Co-authored-by: Tom Lienard <[email protected]>
Co-authored-by: Tom Lienard <[email protected]>
install
when autofixing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few commits to add support for Bun & refactor a bit the code. Tested and seems to work fine, so I'll merge this soon. Thanks again for the help!
Great! Looking forward to having this merged |
Closes #38 & part of #68
This is my first time writing Rust so feel free to help me learn😅
Right now the implementation runs after
--fix
unless--no-install
is passed and tries to detect the package manager.Features:
--fix
or-f
--no-install