'mark as read' fling option #2

[JoshAusHessen]

Second try to add this feature.

Added all feature changes to the changes happening on origin.

[JoshAusHessen]

Only the Errors, existing in the QuantumBadger:master branch, come up.

[codeofdusk]

I've opened JoshAusHessen#2.

@JoshAusHessen Could you please merge that into your branch?

[QuantumBadger]

Thanks both!

@codeofdusk It's probably best to make your changes as a separate PR in this repo -- I'm planning to review and merge this PR now.

[codeofdusk]

@QuantumBadger Done, as #1049.

[QuantumBadger]

@JoshAusHessen Thanks for the PR! I've tested this locally and it doesn't have any effect -- I think pref_behaviour_fling_post_actions hasn't been updated (it looks like pref_menus_post_context_items got updated instead). Would you mind fixing and testing yourself before resubmitting please?

[JoshAusHessen]

So the fling option works.
There is however a issue with the post action menu (I added the 'mark as read' option there as well, just for completions sake).

There are multiple options missing not only the added one:

Also the current master branch brakes, when I open a Subreddit or the main page.
So I'm not sure it that problem is because of my changes.
I may have to wait for a stable commit first.

[QuantumBadger]

The master branch works fine for me, what's the specific error you're getting?

There are multiple options missing not only the added one

That's expected -- options are hidden if they can't be used (e.g. you can't upvote if you're not logged in). The items are added to the menu in RedditPostActions.showActionMenu().

[JoshAusHessen]

The shut down.
In the last you see the git status and git log

error_msg.txt

[QuantumBadger]

@JoshAusHessen It looks like that error is caused by the MARK_READ changes in this PR:

java.lang.IllegalArgumentException: No enum constant org.quantumbadger.redreader.common.PrefsUtility.PostFlingAction.MARK_READ

Something must have gone wrong with the build as that issue shouldn't occur on master.

[JoshAusHessen]

You are too quick for me XD I had some issues with github authentication.
I added the Option to the RedditPostActions.showActionMenu() now both the fling option as well as the PostActionMenu work as intended.

However I also made a clean pull from https://github.com/QuantumBadger/RedReader.git and tried running it on the emulator. There I got again the error as shown above. When I run my fork on the emulator it works. So maybe that can be ignored.

[JoshAusHessen]

Just saw it is already added with #1049... Anyway thx @QuantumBadger @codeofdusk I'm exited for the next update 😄