Fix warming up bug QCAlgorithm.WarmUpIndicator() #8431
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The method
QCAlgorithm.WarmUpIndicator()
was not working properly, since the private methodWarmUpIndicatorImpl<T>()
was keeping the last data point in history. When using a daily consolidator but an hourly symbol, the difference between the history last barEndTime
and the consolidator working bar was not greater than the period (1 day), so the current consolidator working bar was never returned. To fix this, now the method uses the current algorithm time converted to the security timezone.Related Issue
Closes #8405
Motivation and Context
With this change, the method
QCAlgorithm.WarmUpIndicator()
will work correctly when used with a symbol whose resolution differs the consolidator oneRequires Documentation Change
N/A
How Has This Been Tested?
As a regression algorithm, I added the algorithm shared by the user reproducing the bug and asserted the bug was solved.
Types of changes
Checklist:
bug-<issue#>-<description>
orfeature-<issue#>-<description>