Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warming up bug QCAlgorithm.WarmUpIndicator() #8431

Conversation

Marinovsky
Copy link
Collaborator

Description

The method QCAlgorithm.WarmUpIndicator() was not working properly, since the private method WarmUpIndicatorImpl<T>() was keeping the last data point in history. When using a daily consolidator but an hourly symbol, the difference between the history last bar EndTime and the consolidator working bar was not greater than the period (1 day), so the current consolidator working bar was never returned. To fix this, now the method uses the current algorithm time converted to the security timezone.
image
image

Related Issue

Closes #8405

Motivation and Context

With this change, the method QCAlgorithm.WarmUpIndicator() will work correctly when used with a symbol whose resolution differs the consolidator one

Requires Documentation Change

N/A

How Has This Been Tested?

As a regression algorithm, I added the algorithm shared by the user reproducing the bug and asserted the bug was solved.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@Martin-Molinero Martin-Molinero merged commit f431454 into QuantConnect:master Nov 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

warm_up_indicator fails to warm up Stochastic indicator
2 participants