Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daily data time adjustment #8001

Conversation

Martin-Molinero
Copy link
Member

@Martin-Molinero Martin-Molinero commented May 7, 2024

Description

  • Adjust daily data Time & EndTime to actually reflect the time of the
    data used, for example US Equity from 9.30 to 4PM. Adding new unit and
    regression tests. Only for Index and Index Options for now

Related Issue

Closes #6964

Motivation and Context

N/A

Requires Documentation Change

N/A

How Has This Been Tested?

Existing and new tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@Martin-Molinero Martin-Molinero force-pushed the bug-6964-daily-data-time-adjustment branch 2 times, most recently from cc4df36 to 7f11411 Compare May 9, 2024 19:19
@Martin-Molinero Martin-Molinero force-pushed the bug-6964-daily-data-time-adjustment branch 6 times, most recently from 735d277 to 14ca751 Compare May 13, 2024 21:09
- Adjust daily data Time & EndTime to actually reflect the time of the
  data used, for example US Equity from 9.30 to 4PM. Adding new unit and
  regression tests
@Martin-Molinero Martin-Molinero force-pushed the bug-6964-daily-data-time-adjustment branch from 14ca751 to 7480ef0 Compare May 15, 2024 22:36
- Refactor daily strict end times solution to be through enumerator
  usage, so it applies for history providers too
@Martin-Molinero Martin-Molinero force-pushed the bug-6964-daily-data-time-adjustment branch from 7480ef0 to 571de4f Compare May 15, 2024 23:16
@Martin-Molinero Martin-Molinero force-pushed the bug-6964-daily-data-time-adjustment branch 3 times, most recently from 7f5a6f5 to b560e87 Compare May 17, 2024 21:37
- Revert FillForward enumerator causing stats changing, enhancing unit
  tests
@Martin-Molinero Martin-Molinero force-pushed the bug-6964-daily-data-time-adjustment branch 3 times, most recently from cdc4a0e to 000361e Compare May 18, 2024 22:34
@Martin-Molinero Martin-Molinero force-pushed the bug-6964-daily-data-time-adjustment branch from 000361e to 8cb65f4 Compare May 18, 2024 23:02
- Improve handling of live trading FF enumerator, by adding support for
  bars to arrive with a delay so we can handle auction close/option
  prices or data providers which might have some delay making the data
  available. Adding new unit tests asserting the behavior
@Martin-Molinero Martin-Molinero merged commit d4e7f58 into QuantConnect:master May 20, 2024
13 of 14 checks passed
@Martin-Molinero Martin-Molinero deleted the bug-6964-daily-data-time-adjustment branch May 20, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reprocess Daily Data to Exchange Timezone / Address SPX Issue
1 participant