Include chat histories #584
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary because otherwise, after discarding system prompts, the list of prompts in the test will be empty, which violates our assumption that we will always have at least one user message.
smokestacklightnin
force-pushed
the
assistants/include-chat-histories
branch
from
9f32507 to
8199c2f
Compare
pmeier
reviewed
May 20, 2025
Member
pmeier
left a comment
pmeier
left a comment
There was a problem hiding this comment.
Only the Ollama assistant is tested because I do not have API keys for the remaining assistants, but it is identical logic across them all.
This is not your fault or responsibility, but we shouldn't merge without testing them. Let me work on a solution for that.
pmeier
reviewed
May 21, 2025
Contributor
Author
|
I have tested the Anthropic assistant, and it appears to be working:
CC: @pmeier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sends the full chat histories for each prompt for all assistants.
Only the Ollama assistant is tested because I do not have API keys for the remaining assistants, but it is identical logic across them all.
Edit: I have tested the Anthropic assistant locally and it appears to work