Skip to content

Call generic_visit in all paths and bail out early in all visit methods #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lysnikolaou
Copy link
Member

@lysnikolaou lysnikolaou commented Jun 23, 2025

  • Not calling generic_visit in all paths meant that we we missing some usages of thread-unsafe functions.
  • Checking self.thread_unsafe in visit makes sure that we don't miss it if we add more visit_* methods in the future.

@ngoldbaum
Copy link
Contributor

For all these PRs, would you mind doing a quick before/after on SciPy and Scikit-Learn like on the last PR?

It also might be more efficient for everyone if you just to one pull request instead of a series, since I think I'm going to ask you to do more or less the same checks on every PR.

@lysnikolaou
Copy link
Member Author

Yeah, I'll be posting a before/after for all PRs.

I'm a bit hesitant to do one big PR since it's gonna be quite a bit harder to review. But I'm okay to close this and open one big one if you feel like it'll work better for you.

@ngoldbaum
Copy link
Contributor

I can review it commit by commit, just try to keep the commit history nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants