Skip to content

Add an option to skip thread-unsafe tests #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 10, 2025

Conversation

ngoldbaum
Copy link
Contributor

@ngoldbaum ngoldbaum commented Jun 10, 2025

Fixes #72.

Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one minor comment.

@@ -183,14 +193,21 @@ def pytest_itemcollected(item):
]
skipped_functions = frozenset((".".join(x[:-1]), x[-1]) for x in skipped_functions)

skip_thread_unsafe = item.config.option.skip_thread_unsafe
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed, right?

@ngoldbaum ngoldbaum merged commit 6c17059 into Quansight-Labs:main Jun 10, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a way to skip tests marked as thread-unsafe
2 participants