Enable instance initialization #1666
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElePT
reviewed
Jun 27, 2025
There was a problem hiding this comment.
Just looking at the changes, they look good, and I think having everything explicitly defined (channel, instance, etc) in the intialization makes the pipeline cleaner. However, the main point we need to be careful about is the user interaction with these changes. How do you suggest to go about the testing process, does it make to run some local tests or wait for the deployment in dev?
korgan00
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR configures the instance in the initialization of the client to enable to use the instance when you are using the
ibm_quantumchannel.Details and comments
To be able to send the instance in the initialization some changes in the API needed to be done. Now we send also the
channelso we can use internally the instance independently from thechannelthat the user selects.