Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #398: Qbeast Spark Refactor -- Delta abstraction #446

Merged
merged 10 commits into from
Oct 28, 2024

Conversation

JosepSampe
Copy link
Member

@JosepSampe JosepSampe commented Oct 24, 2024

Description

Merge Refactoring Branch into Main #447
Final part of #398

* Abstract the QbeastSnapshot from Delta Snapshot
…beast-io#421)

* Abstract PreCommitHook

* Abstract StagingDataManager

* Propagate stats

* Update MetadataManager

* Update MetadataWriter

* Update MetadataManager

* Add static typing

* Update QbeastFileUtils

* Fix IndexFile stats

* Update DeleteFile logic

* Update qbeast files
…t-io#423)

* Update rollup data writer

* Abstract QbeastStats

* Update QbeastStats to use Number

* Update QbeastStats to use String

* Update QbeastStats

* Update QbeastStats Delta
* Code refactoring: Use Qbeast abstractions instead of Delta imports
* Separate modules between src, core and delta
* Set dataChange to false on Table.optimize()
@JosepSampe JosepSampe self-assigned this Oct 24, 2024
@JosepSampe JosepSampe changed the base branch from feat-refactor to main October 24, 2024 13:47
@JosepSampe JosepSampe changed the title Issue #382: Update refactor branch with main changes Issue #382: Merge Refactoring Branch into Main Oct 24, 2024
Copy link
Member

@osopardo1 osopardo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments left! Some of them can be solved here, others would be best to leave it for another discussion.
Let me know what do you think 🙏

The rest looks goooood

@osopardo1 osopardo1 self-requested a review October 25, 2024 10:55
@JosepSampe JosepSampe changed the title Issue #382: Merge Refactoring Branch into Main Issue #398: Qbeast Spark Refactor: Delta abstraction Oct 26, 2024
@osopardo1
Copy link
Member

Just one small thing that we notice!!

We should NOT update the README documentation. The only document that should be updated with developments is Contributing.md (developer docs), so maintainers and devs can test with the proper configuration.

But for regular users, copying and pasting from the docs would not work with the new packages and the latest version 0.7.0.

CONTRIBUTING.md Outdated Show resolved Hide resolved
@fpj fpj changed the title Issue #398: Qbeast Spark Refactor: Delta abstraction Issue #398: Qbeast Spark Refactor -- Delta abstraction Oct 28, 2024
@osopardo1 osopardo1 merged commit de19c2e into Qbeast-io:main Oct 28, 2024
1 check passed
@JosepSampe JosepSampe deleted the refactormergemain branch November 21, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants