-
Notifications
You must be signed in to change notification settings - Fork 563
Remove sorting from tabular_writer
#3804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jsiirola
wants to merge
21
commits into
Pyomo:main
Choose a base branch
from
jsiirola:tabular-writer-nosorting
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+501
−209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3804 +/- ##
=======================================
Coverage 89.41% 89.42%
=======================================
Files 909 909
Lines 105579 105619 +40
=======================================
+ Hits 94407 94447 +40
Misses 11172 11172
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Supersedes #3578.
Summary/Motivation:
This removes all sorting from the
tabular_writer, and prints out the data in the order in which the data iterator provides it. Control for sorting intpprint()is now exposed through thepprint()API. This makes thetabular_writersimpler / more generic and more usable in other contexts.This is currently backwards compatible with the existing
pprint()infrastructure and will produce the same output. A subsequent PR will rework thepprint()design so that components are output in "ordered" (and not "sorted") order, as well as other changes that might break the output.Changes proposed in this PR:
pprint()private API so that sorting can be controlled by an optional argument topprint()Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: