-
-
Notifications
You must be signed in to change notification settings - Fork 479
fix: VoiceClient crashes while receiving audio #2800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Hema2 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thx for the fix
@Hema2-official Please edit your message so that you have a line with the following format: fixes: #2644 So that the pr is marked as fixing that issue |
|
Also @Hema2-official add a changelog under Fixed please, take a look at |
Github died, i guess |
build is re-running |
fkng rtd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revoking my approval - Changelog needed
Add the changelog @Hema2-official and we're good to go |
It just worked |
Thanks for the edit, @Lulalaby 🫂 I'll add the changelog rq! |
Signed-off-by: Hema2 <[email protected]>
Done, y'all can merge! |
Summary
I fixed issue #2644.
The problem was a length check taking place after byte checks.
I did extensive testing and it seems to completely get rid of the seemingly random crashes.
fixes: #2644
Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.