Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process all Sendgrid Events #5

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

noelwelsh
Copy link
Contributor

Extend the Sendgrid event handler to process all events received from
Sendgrid (using the Event Webhook v3 API). This includes email views,
email clicks, unsubscribes, spam reports, and bounces.

The endpoint uses basic auth to provide a bit of protection against
attack. The username and password are set in the SENDGRID_USER and
SENDGRID_PASSWORD environment variables respectively. They default to
sendgrid (both username and password) if not set. When configuring
Sendgrid these parameters must be set as described in the Sendgrid
documentation.

All event processing goes via delayed job to even out load.

If you use Platform's event tracking this can lead to double
counting. There isn't a general solution to this as multiple opens,
views, etc. are valid. However, double counting isn't likely to
make much difference in practice.

Noel Welsh added 6 commits February 28, 2014 10:04
Extend the Sendgrid event handler to process all events received from
Sendgrid (using the Event Webhook v3 API). This includes email views,
email clicks, unsubscribes, spam reports, and bounces.

The endpoint uses basic auth to provide a bit of protection against
attack. The username and password are set in the SENDGRID_USER and
SENDGRID_PASSWORD environment variables respectively. They default to
sendgrid (both username and password) if not set. When configuring
Sendgrid these parameters must be set as described in the Sendgrid
documentation.

All event processing goes via delayed job to even out load.

If you use Platform's event tracking this can lead to double
counting. There isn't a general solution to this as multiple opens,
views, etc. are valid. However, double counting isn't likely to
make much difference in practice.
credentials

The SendGrid event handler was reusing the SendGrid API credentials. I
decided this was a bad idea and it should have its own credentials, as
they will probably be less secure.
For greater insight into what is happening with event processing, track
events and errors with New Relic custom metric under the
Custom/SendgridEvent path.
SendGrid has flattened their JSON format for events. Match that change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant