Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom Topology #26

Closed
wants to merge 4 commits into from
Closed

Add custom Topology #26

wants to merge 4 commits into from

Conversation

SimonBoothroyd
Copy link
Collaborator

Description

This PR adds a new Topology object as a replacement for the currently used parmed.Structure. The parmed.Structure is not really maintained any longer, and somewhat limited in terms of flexibility and features.

The new Topology should be seen as basically a modernisation of the OpenMM topology, with atom selection features similar to mdtraj, pymol, etc.

Status

  • Ready to go

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 95.99332% with 24 lines in your changes missing coverage. Please review.

Project coverage is 95.68%. Comparing base (4023514) to head (512367e).

Files with missing lines Patch % Lines
femto/top/_top.py 95.07% 19 Missing ⚠️
femto/top/_sel.py 97.44% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   95.62%   95.68%   +0.06%     
==========================================
  Files          46       51       +5     
  Lines        3039     3638     +599     
==========================================
+ Hits         2906     3481     +575     
- Misses        133      157      +24     
Flag Coverage Δ
unittests 95.68% <95.99%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SimonBoothroyd
Copy link
Collaborator Author

closed in favour of a standalone package, mdtop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant