Skip to content

Simplify Storage::rounds map. #3602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: staging
Choose a base branch
from
Open

Simplify Storage::rounds map. #3602

wants to merge 1 commit into from

Conversation

acoglio
Copy link
Collaborator

@acoglio acoglio commented Apr 21, 2025

Since certificate ID and batch ID are always the same, we can simplify this map to avoid having two identical IDs, and having just one instead.

@acoglio
Simplify Storage::rounds map.
657e77b 
Since certificate ID and batch ID are always the same, we can simplify this map
to avoid having two identical IDs, and having just one instead.
@acoglio acoglio requested review from raychu86 and kaimast April 21, 2025 12:51
raychu86
raychu86 approved these changes Apr 25, 2025
View reviewed changes
Copy link
Collaborator

@raychu86 raychu86 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fairly straightforward.

Might be worth checking if any of our documentation (inside or outside snarkOS) that considers batch_id and certificate_id different or separate things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raychu86 raychu86 raychu86 approved these changes

@kaimast kaimast Awaiting requested review from kaimast

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acoglio @raychu86