Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cycleway value should fall back to cycleway:both if available #6180

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Nate-Wessel
Copy link

fixes #6179

@mjjbell
Copy link
Member

mjjbell commented Dec 21, 2021

@Nate-Wessel can you include cycleway:both in the feature tests to ensure it also has coverage?

@Nate-Wessel
Copy link
Author

Alas, I'd be happy to contribute further but I'm really not sure what I'm looking at with the feature tests there. I think I'd be as likely to break something as fix it.

@DennisOSRM
Copy link
Collaborator

closing stale PR. Reopen if still relevant.

@DennisOSRM DennisOSRM closed this May 10, 2024
@Nate-Wessel
Copy link
Author

closing stale PR. Reopen if still relevant.

I would like to reopen this, but don't see the option to do so. How do I reopen?

@DennisOSRM DennisOSRM reopened this May 11, 2024
@DennisOSRM
Copy link
Collaborator

Reopened

@DennisOSRM
Copy link
Collaborator

I guess all we'd need with this PR would be a test case that covers the change.

@Nate-Wessel
Copy link
Author

I'll be happy to add a test case if you can point me toward how I would do that. Is there any documentation?

@DennisOSRM
Copy link
Collaborator

Have a look at testing docs. The section where it says 'Cucumber' is probably the most interesting one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider cycleway:both in addition to cycleway for bicycle profile
3 participants