-
Notifications
You must be signed in to change notification settings - Fork 0
Add md5 and basename file parsers #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Closes #8 I updated the config code to use default resources from the toml instead of the hard coded values. The configuration toml is now documented in the readme and when the user omits the toml option they get an error telling them it's required and to check the readme for an example. Need to still work on categorical inputs that are paths (handling, warning, etc). This is good to merge now though, can add the rest later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks good. I just left a few comments in the README
# can be overwritten by subsequent jobs | ||
# if not set, will use 1000 for default memory and 60 for default runtime | ||
default_mem = 2000 | ||
default_time = 70 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default_time = 70 | |
default_time = 60 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, but I had this as 70 to show it could be different than the defaults when nothing is provided (1000 and 60).
README.md
Outdated
# /^>/ {next} | ||
# {seq = seq + length($0)} | ||
# END {if (seq) print seq} | ||
''' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you forgot the opening of these.
Co-authored-by: Ioannis Paraskevakos <[email protected]>
Check if you need to strip quotations from filenames for categoricals and files
Detect if categorical has file (hd5) separators, warn user and escape to store as categorical