Slideshow: Add devscript support #2228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcrisman
reviewed
Jul 22, 2024
|
|
||
| # Consult publisher file for locations of images | ||
| generated_abs, external_abs = get_managed_directories(xml, pub_file) |
There was a problem hiding this comment.
This line will make me very happy 😄
rbeezer
pushed a commit
that referenced
this pull request
Jul 27, 2024
|
Thanks, Sean! Very close. Needed to build the outpt file name ( Some stuff near the end was then not really necessary until we have an option to zip everything together, especiually in hte case where we want to copy over the necessary resources (the actual Reveal JS and CSS). So I got rid of that for now. Perhaps something similar will come back. See new issue, #2235 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to
pretext/pretextandpretext/pretext.pyto add support for reveal.js slides.It is working for me, but my Python is not great, so another set of eyes is needed.
Note that I didn't add a reveal-zip target. I'm not sure if that would be wanted.