Add support for inset margins of FrameSvgItems #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SVG items can currently define a "inset" property that defines how much inset the element should have. The use case for this is e.g. including a shadow around the element and then setting the inset to be the same size as the shadow.
Prayag2
reviewed
Jan 25, 2023
| anchors.topMargin: -rect.inset.top + PlasmaCore.Units.smallSpacing * 1.5 | ||
| anchors.leftMargin: -rect.inset.left + PlasmaCore.Units.smallSpacing * 1.5 | ||
| anchors.rightMargin: -rect.inset.right + PlasmaCore.Units.smallSpacing * 1.5 | ||
| anchors.bottomMargin: -rect.inset.bottom + PlasmaCore.Units.smallSpacing * 1.5 |
There was a problem hiding this comment.
But now they'll not respect the scale of the applet? There's an option in the settings to increase or decrease the scale of the applet to make it larger or smaller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SVG items can currently define a "inset" property that defines how much inset the element should have. The use case for this is e.g. including a shadow around the element and then setting the inset to be the same size as the shadow.
The idea is that this shouldn't change much unless you're using inset. However, I do change how margins work, since they were previously used to define the margin outside the element, and now they're used to define the margin inside them, as I thought was more appropriate.