Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 tests: use testcontainers #79

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Conversation

ahouene
Copy link
Contributor

@ahouene ahouene commented Oct 14, 2024

Remove internal s3testing package and companion files in favour of testcontainers, as suggested in #61.

Remove internal s3testing package in favour of testcontainers, as suggested in PowerDNS#61.
@ahouene ahouene linked an issue Oct 14, 2024 that may be closed by this pull request
Copy link

@johanlantz johanlantz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ahouene ahouene merged commit c412150 into PowerDNS:main Oct 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider using testcontainers for s3 backend tests
2 participants