auth 4.8.x: Backport "Damage control in Lua createForward() and createForward6()." #15229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding the |
miodvallat
force-pushed
the
backport-15222-to-auth-4.8.x
branch
2 times, most recently
from
3ffd352 to
a5127b1
Compare
- make sure all computed results are passed to a ComboAddress
constructor, which will reject ill-formed data. This wasn't the case
in createForward, when interpreting part of the requested name as an
ipv4 address encoded in hexadecimal (e.g. 7f000001), but the actual
name wasn't.
This would otherwise end up with a SERVFAIL answer and a Lua stack
traceback containing messages such as:
Unable to convert presentation address '4294967292.xx.yy.zz'
for a name ending with "-4" and six hex digits.
- wrap these functions into a try/catch block in order to cope with
possible exceptions raised by ComboAddress.
This wasn't the case in createForward6 when the requested name
contains at least 8 dots - this doesn't imply each component is a
valid ipv6 chunk.
(cherry picked from commit 9780054)
(backport from master)
miodvallat
force-pushed
the
backport-15222-to-auth-4.8.x
branch
from
a5127b1 to
cc83eb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Backport of #15222
Checklist
I have: