Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: reinstate artifact generation for PRs #15187

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

Habbie
Copy link
Member

@Habbie Habbie commented Feb 20, 2025

Short description

This got removed in #14767 by accident.

I tested that this works without any variables or secrets by pushing to master on a fork, without this patch.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

Copy link
Contributor

@miodvallat miodvallat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure this can't make anything worse. 🤞🏻

@coveralls
Copy link

coveralls commented Feb 20, 2025

Pull Request Test Coverage Report for Build 13442483538

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 29 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+3.8%) to 64.505%

Files with Coverage Reduction New Missed Lines %
ext/json11/json11.cpp 2 62.72%
modules/lmdbbackend/lmdbbackend.cc 2 73.86%
pdns/opensslsigners.cc 2 61.0%
pdns/recursordist/rec-main.cc 2 48.67%
pdns/iputils.cc 3 55.76%
pdns/recursordist/syncres.cc 3 75.71%
pdns/misc.cc 4 61.8%
pdns/recursordist/aggressive_nsec.cc 5 64.91%
pdns/dnsdistdist/dnsdist-carbon.cc 6 61.7%
Totals Coverage Status
Change from base Build 13433765276: 3.8%
Covered Lines: 127653
Relevant Lines: 166895

💛 - Coveralls

@Habbie Habbie merged commit bf18889 into PowerDNS:master Feb 24, 2025
87 checks passed
@Habbie Habbie deleted the docs-pr-artifact branch February 24, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants