docs: Update to primary/secondary #15185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoref
commented
Feb 20, 2025
jsoref
force-pushed
the
primary-secondary
branch
from
0ba31d2 to
d5781de
Compare
jsoref
commented
Feb 20, 2025
| signing-slave. | ||
| This setting will make PowerDNS renotify the secondaries after an AXFR is | ||
| *received* from a primary. This is useful when running a | ||
| signing-secondary. |
There was a problem hiding this comment.
this is kinda different... nothing else used this terminology...
Pull Request Test Coverage Report for Build 13457629632Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
miodvallat
reviewed
Feb 20, 2025
jsoref
force-pushed
the
primary-secondary
branch
2 times, most recently
from
3e643b2 to
4c1b309
Compare
jsoref
commented
Feb 20, 2025
docs/settings.rst
Outdated
| @@ -1860,7 +1860,7 @@ and :doc:`Virtual Hosting <guides/virtual-instances>` how this can differ. | |||
| - Boolean | |||
| - Default: no | |||
|
|
|||
| Turn on supermaster support. See :ref:`supermaster-operation`. | |||
| Turn on supermaster support. See :ref:`autoprimary-operation`. | |||
There was a problem hiding this comment.
This line is a bit odd. I'm not changing the visible text because I can't reason through it.
I'm also not removing the dangling anchors because I see no reason to break external references
There was a problem hiding this comment.
This is obviously a cut'n'paste error, it should read Turn on superslave or Turn on autosecondary.
jsoref
commented
Feb 20, 2025
Signed-off-by: Josh Soref <[email protected]>
jsoref
force-pushed
the
primary-secondary
branch
from
4c1b309 to
aada15d
Compare
The docs had been wrong since the feature was renamed in d3dfd71 Signed-off-by: Josh Soref <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Checklist
I have: