Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth, check return value of getCatalogMembers() #15093

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

mind04
Copy link
Contributor

@mind04 mind04 commented Jan 28, 2025

Short description

Parse errors in getCatalogMembers() did result in a valid but empty catalog zone.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@coveralls
Copy link

coveralls commented Jan 28, 2025

Pull Request Test Coverage Report for Build 13030285875

Details

  • 1 of 6 (16.67%) changed or added relevant lines in 1 file are covered.
  • 52 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-0.003%) to 64.696%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/tcpreceiver.cc 1 6 16.67%
Files with Coverage Reduction New Missed Lines %
pdns/distributor.hh 2 51.86%
pdns/tsigverifier.cc 3 77.22%
pdns/remote_logger.cc 3 54.26%
pdns/recursordist/recpacketcache.hh 3 89.55%
modules/gpgsqlbackend/spgsql.cc 3 67.7%
pdns/recursordist/pdns_recursor.cc 3 72.65%
pdns/recursordist/test-syncres_cc1.cc 5 89.76%
pdns/iputils.cc 6 56.07%
pdns/recursordist/syncres.cc 10 80.07%
pdns/recursordist/rec-system-resolve.cc 14 48.98%
Totals Coverage Status
Change from base Build 13005788889: -0.003%
Covered Lines: 127817
Relevant Lines: 166475

💛 - Coveralls

@Habbie Habbie merged commit 945ec8e into PowerDNS:master Feb 3, 2025
81 checks passed
@mind04 mind04 deleted the auth-catalog-fix branch February 3, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants