Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: allow setting keyLogFile to DoT/DoH backends #14938

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

karelbilek
Copy link
Contributor

@karelbilek karelbilek commented Dec 6, 2024

Short description

This adds keyLogFile setting to DoT and DoH backends.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code - tested with wireshark + google's DoH backend
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

The regression tests just try if the logfiles exist and are non-empty, they don't really check what is in them.

@karelbilek karelbilek changed the title Allow setting keyLogFile to DoT/DoH backends dnsdist: allow setting keyLogFile to DoT/DoH backends Dec 6, 2024
@coveralls
Copy link

coveralls commented Dec 6, 2024

Pull Request Test Coverage Report for Build 12236041428

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 9 of 11 (81.82%) changed or added relevant lines in 4 files are covered.
  • 28 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.04%) to 64.743%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/dnsdistdist/doh.cc 0 1 0.0%
pdns/tcpiohandler.cc 3 4 75.0%
Files with Coverage Reduction New Missed Lines %
pdns/recursordist/syncres.cc 1 79.38%
pdns/signingpipe.cc 2 83.65%
pdns/recursordist/aggressive_nsec.cc 2 66.25%
modules/lmdbbackend/lmdbbackend.cc 2 72.54%
pdns/recursordist/test-syncres_cc2.cc 3 88.85%
pdns/remote_logger.cc 3 53.81%
pdns/iputils.cc 3 55.76%
pdns/recursordist/test-syncres_cc1.cc 5 89.78%
pdns/recursordist/rec-main.cc 7 62.48%
Totals Coverage Status
Change from base Build 12234956497: 0.04%
Covered Lines: 125883
Relevant Lines: 163529

💛 - Coveralls

@rgacogne rgacogne added this to the dnsdist-2.0.0 milestone Dec 9, 2024
@rgacogne rgacogne self-requested a review December 9, 2024 08:25
@karelbilek karelbilek force-pushed the keylogfile_master branch 2 times, most recently from f58828a to 4aadf7f Compare December 9, 2024 08:38
@karelbilek karelbilek force-pushed the keylogfile_master branch 2 times, most recently from 05c9ba2 to e5bcbd8 Compare December 9, 2024 08:47
Copy link
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good to me, I requested two very small changes for consistency's sake. Thanks a lot!

pdns/tcpiohandler.cc Outdated Show resolved Hide resolved
pdns/tcpiohandler.hh Outdated Show resolved Hide resolved
@karelbilek
Copy link
Contributor Author

I haven't been able to run the regression tests locally so far, and they don't seem to be run in CIs on PR... should I try more? :)

@rgacogne
Copy link
Member

rgacogne commented Dec 9, 2024

I haven't been able to run the regression tests locally so far, and they don't seem to be run in CIs on PR... should I try more? :)

They are, what makes you think otherwise?

@rgacogne
Copy link
Member

rgacogne commented Dec 9, 2024

(look for Build and test everything / test-dnsdist-regression)

There is no test for actual validity of the files... just if there is something there.
Copy link
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@rgacogne rgacogne merged commit f0794c9 into PowerDNS:master Dec 9, 2024
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants