-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dnsdist: allow setting keyLogFile to DoT/DoH backends #14938
Conversation
47afbfe
to
0cc286e
Compare
Pull Request Test Coverage Report for Build 12236041428Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
0cc286e
to
6905b80
Compare
f58828a
to
4aadf7f
Compare
05c9ba2
to
e5bcbd8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good to me, I requested two very small changes for consistency's sake. Thanks a lot!
I haven't been able to run the regression tests locally so far, and they don't seem to be run in CIs on PR... should I try more? :) |
They are, what makes you think otherwise? |
(look for |
There is no test for actual validity of the files... just if there is something there.
e5bcbd8
to
d515a8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
Short description
This adds keyLogFile setting to DoT and DoH backends.
Checklist
I have:
The regression tests just try if the logfiles exist and are non-empty, they don't really check what is in them.