Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re: followup to 14796: also call stop hook in 1 thread case #14909

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

omoerbeek
Copy link
Member

Short description

The stop hook was not called in the threads=1 case. This looks better from a symmetry point of view as well.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@omoerbeek omoerbeek added this to the rec-5.2.0 milestone Dec 2, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12115370868

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 52 unchanged lines in 15 files lost coverage.
  • Overall coverage decreased (-0.005%) to 64.689%

Files with Coverage Reduction New Missed Lines %
ext/json11/json11.cpp 1 64.49%
pdns/pollmplexer.cc 1 83.66%
pdns/recursordist/aggressive_nsec.cc 2 66.02%
pdns/sstuff.hh 2 56.83%
pdns/backends/gsql/gsqlbackend.hh 2 97.71%
pdns/recursordist/test-syncres_cc2.cc 3 88.91%
pdns/stubresolver.cc 3 77.58%
pdns/packethandler.cc 3 72.48%
pdns/remote_logger.cc 3 53.36%
pdns/misc.cc 3 63.77%
Totals Coverage Status
Change from base Build 12087438521: -0.005%
Covered Lines: 125857
Relevant Lines: 163646

💛 - Coveralls

@omoerbeek omoerbeek merged commit 374a7d3 into PowerDNS:master Dec 2, 2024
78 checks passed
@omoerbeek omoerbeek deleted the rec-startstop-fix branch December 2, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants