Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist-1.9.x: Backport of #14850 - add elapsed time to dq object #14887

Merged
merged 1 commit into from
Dec 13, 2024
Merged

dnsdist-1.9.x: Backport of #14850 - add elapsed time to dq object #14887

merged 1 commit into from
Dec 13, 2024

Conversation

rgacogne
Copy link
Member

Short description

Backport of #14850 to rel/dnsdist-1.9.x

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@rgacogne
Elapsed lua binding
9fd070b 
(cherry picked from commit d31fa78)
@rgacogne rgacogne added this to the dnsdist-1.9.x milestone Nov 26, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12027466348

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 11 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.05%) to 55.761%
Files with Coverage Reduction New Missed Lines %
pdns/iputils.hh 3 75.0%
pdns/dnsdist-tcp.cc 4 76.42%
ext/yahttp/yahttp/url.hpp 4 30.09%
Totals Coverage Status
Change from base Build 12026870943: -0.05%
Covered Lines: 48093
Relevant Lines: 65635
💛 - Coveralls

omoerbeek
omoerbeek reviewed Dec 9, 2024
View reviewed changes
pdns/dnsdistdist/docs/reference/dq.rst
@@ -131,6 +131,14 @@ This state can be modified from the various hooks.

:returns: A table of EDNSOptionView objects, indexed on the ECS Option code

.. method:: DNSQuestion::getElapsedUs -> double

.. versionadded:: 2.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add 1.9.x version

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing it in rel/dnsdist-1.9.x will not help, but I need to do that in master indeed!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in #14947

@rgacogne rgacogne mentioned this pull request Dec 9, 2024
Merged
7 tasks
@rgacogne rgacogne requested a review from omoerbeek December 9, 2024 15:50
@rgacogne rgacogne merged commit df6510b into PowerDNS:rel/dnsdist-1.9.x Dec 13, 2024
12 checks passed
@rgacogne rgacogne deleted the ddist19-backport-14850 branch December 13, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omoerbeek omoerbeek omoerbeek approved these changes

@chbruyand chbruyand Awaiting requested review from chbruyand

Assignees
No one assigned
Labels
dnsdist enhancement
Projects
None yet
Milestone
dnsdist-1.9.x
Development

Successfully merging this pull request may close these issues.
3 participants
@rgacogne @coveralls @omoerbeek