👷 WORK IN PROGRESS 🚧 No path in directory metadata - Fixes issue #14 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead of `git`.
…eAuthenticated`.
…e `getContentApi`.
…rectory into a separate method.
…etDirectoryContents`.
…e correct `filterTreeData`.
…normalization method.
Potherca
changed the title
Current coverage is 88.00%@@ develop #15 diff @@
=========================================
Files 3 3
Lines 264 325 +61
Methods 51 57 +6
Branches 0 0
=========================================
+ Hits 245 286 +41
- Misses 19 39 +20
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👷 WORK IN PROGRESS 🚧
As the previous round of work missed out an important piece of functionality in regards to directory metadata, I took the opportunity of fixing that issue to do another round of work.
Besides fixing issue #14, logic in regards to file and folder timestamps has been improved, the groundwork for tests to use fixtures has been added, the code has been cleanup up further (more DRY, avoid hard-coded values, more descriptive method names) and "caching" of request values has been added.