test(io): add test_so_reuseport_zero_downtime_handover#4715
Open
mkleczek wants to merge 1 commit intoPostgREST:mainfrom
Open
test(io): add test_so_reuseport_zero_downtime_handover#4715mkleczek wants to merge 1 commit intoPostgREST:mainfrom
mkleczek wants to merge 1 commit intoPostgREST:mainfrom
Conversation
mkleczek
force-pushed
the
test_so_reuseport_zero_downtime_handover
branch
from
3599134 to
f7e84bd
Compare
mkleczek
force-pushed
the
test_so_reuseport_zero_downtime_handover
branch
2 times, most recently
from
1427790 to
2274d2f
Compare
mkleczek
force-pushed
the
test_so_reuseport_zero_downtime_handover
branch
from
2274d2f to
cdfbff3
Compare
Comment on lines
+152
to
+159
| # 1. Start first PostgREST instance | ||
| # 2. Start a "client" thread issuing requests in a loop | ||
| # remembering all received errors | ||
| # 3. Start second PostgREST instance on the same port as the first one | ||
| # 4. Wait a little and terminate the first instance | ||
| # 5. Stop client thread | ||
| # 6. Stop second PostgREST instance | ||
| # 7. Verify client did not get any errors |
Member
There was a problem hiding this comment.
Thanks, this is better. I'm not sure if I understand this part though:
- Start second PostgREST instance on the same port as the first one
- Wait a little and terminate the first instance
- Stop client thread
During this time, the client thread is expected to hit the endpoints of the 2nd instance and succeed?
So between step 4 and 5 the second instance takes over and starts serving over the same port?
If that's the case, having that as a comment would be clarifying.
- Start second PostgREST instance on the same port as the first one
Also I guess now the above fails immediately since the port is taken?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DISCLAIMER:
This commit was authored entirely by a human without the assistance of LLMs.
Test validating zero-downtime deployments with
SO_REUSEPORT. Marked asxfailto make sure it fails.Prerequisite of: #4703