refactor: move checkIsFatal logic to usePool #3524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fatal logic is now inside `usePool`. It centralizes the logic which is better for Locality of Behavior. Removes: - The need to do checkIsFatal on other parts of the code - SCFatalFail/ConnFatalFail states which are no longer needed.
steve-chavez
force-pushed
the
scache-backoff
branch
from
fdda311
to
31fcf04
Compare
steve-chavez
commented
May 16, 2024
Comment on lines
+253
to
+257
| -- Check for a syntax error (42601 is the pg code) only for queries that don't have `WITH pgrst_source` as prefix. | ||
| -- This would mean the error is on our schema cache queries, so we treat it as fatal. | ||
| -- TODO have a better way to mark this as a schema cache query | ||
| SQL.ServerError "42601" _ _ _ _ -> | ||
| unless ("WITH pgrst_source" `BS.isPrefixOf` tpl) $ do |
There was a problem hiding this comment.
This was added on https://github.com/PostgREST/postgrest/pull/1685/files#diff-328c2f3103b25df9c32be37811eabc32ea0f39cea4f860b33651b3d470adf974R221. To preserve behavior I'm marking it here to only act on schema cache queries because on older pg versions 42601 also appears on API queries, in particular when inserting on generated columns.
postgrest/test/spec/Feature/Query/InsertSpec.hs
Lines 550 to 571 in d25df45
steve-chavez
commented
May 16, 2024
| actualPgVersion <- getPgVersion appState | ||
| when (actualPgVersion < minimumPgVersion) $ do | ||
| observer $ ExitUnsupportedPgVersion actualPgVersion minimumPgVersion | ||
| killThread mainThreadId |
There was a problem hiding this comment.
coverage failing because we have no way of testing when we quit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards solving #3523
The fatal logic is now inside
usePool. It centralizes the logic which is better for Locality of Behavior.Removes: