Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't hide error on LISTEN channel failure #3323

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

steve-chavez
Copy link
Member

Related to #3313.

Now when the LISTEN channel dies we log:

11/Mar/2024:14:11:11 -0500: FatalError {fatalErrorMessage = "Error checking for PostgreSQL notifications"}. Retrying listening for notifications on the pgrst channel..

It used to be:

11/Mar/2024:12:50:17 -0500: Retrying listening for notifications on the pgrst channel..

The lib error is still uninformative but that's another issue #3320 (comment)

@steve-chavez steve-chavez force-pushed the fix-hiding branch 2 times, most recently from 87e573e to 05e3878 Compare March 11, 2024 23:06
@steve-chavez
Copy link
Member Author

Codecov is failing due to #1766

@steve-chavez steve-chavez merged commit 00f5780 into PostgREST:main Mar 12, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant